This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
don't count connections in the grace period against the limit #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
approved these changes
Jul 27, 2019
raulk
approved these changes
Jul 27, 2019
connmgr.go
Outdated
| @@ -229,12 +230,26 @@ func (cm *BasicConnMgr) getConnsToClose(ctx context.Context) []network.Conn { | |||
| // skip over protected peer. | |||
| continue | |||
| } | |||
| if inf.firstSeen.Add(cm.gracePeriod).After(now) { | |||
There was a problem hiding this comment.
I know you only shifted this block from below, but we can precompute the grace threshold only once before entering the loop.
This was referenced Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46
Also, don't count protected connections.